[GEN][ZH] Prevent unlikely buffer overrun while writing to 'newPts' in PolygonTrigger::reallocate()#1091
Merged
xezon merged 1 commit intoTheSuperHackers:mainfrom Jun 21, 2025
Conversation
xezon
added
Minor
…n PolygonTrigger::reallocate()
xezon
force-pushed
the
xezon/staticanalysis2/006
branch
from
a4b8323 to
a9fd1d2
Compare
|
What warning settings are required to get a warning here? I can't replicate it, nor do I really understand what the warning is about. |
Author
|
This warning is created by running the Code Analysis in Visual Studio: https://learn.microsoft.com/en-us/cpp/code-quality/code-analysis-for-c-cpp-overview?view=msvc-170 |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…n PolygonTrigger::reallocate() (TheSuperHackers#1091)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…n PolygonTrigger::reallocate() (TheSuperHackers#1091)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents an unlikely buffer overrun while writing to 'newPts' in PolygonTrigger::reallocate() and makes the compiler happy.